Skip to content

Commit

Permalink
crypto: skcipher - remove the exporting of skcipher_walk_next
Browse files Browse the repository at this point in the history
The function skcipher_walk_next declared as static and marked as
EXPORT_SYMBOL_GPL. It's a bit confusing for internal function to be
exported. The area of visibility for such function is its .c file
and all other modules. Other *.c files of the same module can't use it,
despite all other modules can. Relying on the fact that this is the
internal function and it's not a crucial part of the API, the patch
just removes the EXPORT_SYMBOL_GPL marking of skcipher_walk_next.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Denis Efremov <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
  • Loading branch information
evdenis authored and herbertx committed Jul 1, 2018
1 parent d0d859b commit e4e4730
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion crypto/skcipher.c
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,6 @@ static int skcipher_walk_next(struct skcipher_walk *walk)
}
return err;
}
EXPORT_SYMBOL_GPL(skcipher_walk_next);

static int skcipher_copy_iv(struct skcipher_walk *walk)
{
Expand Down

0 comments on commit e4e4730

Please sign in to comment.