Dark theme change status icons #1423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
love-linger
added a commit
that referenced
this pull request
Jun 16, 2025
Since we have already used `OnPropertyChanged`, move `ActualThemeVariantProperty` changed handler into it Signed-off-by: leo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a minor one, but I feel that the change status icons are a bit too bright when in dark mode.
This PR refactors the brushes in
ChangeStatusIconand dynamically darkens or lightens the gradient color depending on what theme is set. It also listens for theme changes so it can re-render if the user switches.It's pretty subtle right now but a good starting point for theme-aware icon colors.