-
Notifications
You must be signed in to change notification settings - Fork 65
feat(batches): add docs for pushed-only changesets #1200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -36,6 +36,7 @@ Below is a list of supported bulk operations for changesets and the conditions w | |||
| **Merge (experimental)** | Merge the selected changesets on code hosts. Some changesets may be unmergeable due to their states, which does not impact the overall bulk operation. Failed merges are listed under the bulk operations tab. In the confirmation modal, you can opt for a squash merge strategy, available on GitHub, GitLab, and Bitbucket Cloud. For Bitbucket Server/Data Center, only regular merges are performed | | |||
| **Close** | Close the selected changesets on the code hosts | | |||
| **Publish** | Publishes the selected changesets, provided they don't have a [`published` field](/batch-changes/batch-spec-yaml-reference#changesettemplatepublished) in the batch spec. You can choose between draft and normal changesets in the confirmation modal | | |||
| **Push-only** | Pushes code changes to a new branch on a code host without making a merge request. Available on GitHub and GitLab only. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: the bulk operation is called "push" only (verb is active), whereas the non-bulk-op (not documented in this PR) and the reference to the state of the changeset is "pushED" only (e.g. "Look at this pushed-only changeset I made").
|
||
To push code to a new branch on a code host without also creating a merge request, simply select 'push only' from the dropdown menu: | ||
|
||
[image would go here] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on Entitle access to upload pic
@@ -164,7 +166,7 @@ export const navigation: NavigationItem[] = [ | |||
}, | |||
{ title: "Access Permissions", href: "/batch-changes/permissions-in-batch-changes" }, | |||
{ | |||
title: "Changesets in Monorepo", href: "/batch-changes/creating-changesets-per-project-in-monorepos", | |||
title: "Changesets in Monorepos", href: "/batch-changes/creating-changesets-per-project-in-monorepos", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick nit (unrelated to core PR)
@@ -187,7 +189,7 @@ export const navigation: NavigationItem[] = [ | |||
] | |||
}, | |||
{ | |||
title: "Working with CLI", href: "/batch-changes/how-src-executes-a-batch-spec", | |||
title: "Working with the CLI", href: "/batch-changes/how-src-executes-a-batch-spec", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick nit (unrelated to core PR)
@bahrmichael tagging for viz |
@aulorbe You may want to revisit the package lock update and maybe discard that file's changes. I don't see any package updates from you, just doc updates. |
## Requirements | ||
To push code to a new branch on a code host, you will need: | ||
|
||
- [Admin permissions for the batch change](/batch-changes/permissions-in-batch-changes#permission-levels-for-batch-changes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this on Sourcegraph's or GitHub's side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see write access to the code host mentioned below. Does it make sense to call it site-admin here?
Co-authored-by: Michael Bahr <[email protected]>
Co-authored-by: Michael Bahr <[email protected]>
Just removed it, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @aulorbe I added few commits including images to your PR. Good from my side. I still see some unaddressed feedback. Let me know once you're ready and I can merge it to our working branch for 6.5.
This PR adds docs for the push-only bulk operation.
Closes EPD2-10.
Pull Request approval