Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build against gcc-13 (missing <cstdint> includes) #57

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix build against gcc-13 (missing <cstdint> includes) #57

merged 1 commit into from
Feb 14, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Feb 10, 2024

Without the change build fails against gcc-13 as:

/build/source/src/conversion/autocorrelation_to_composite_sinusoidal_modeling.cc:25:1: error: 'uint64_t' does not name a type
   25 | uint64_t CalculateBinomialCoefficient(int n, int k) {
      | ^~~~~~~~
/build/source/src/conversion/autocorrelation_to_composite_sinusoidal_modeling.cc:21:1: note: 'uint64_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
   20 | #include <cmath>      // std::acos, std::fabs, std::pow
  +++ |+#include <cstdint>
   21 | #include <cstddef>    // std::size_t

Without the change build fails against `gcc-13` as:

    /build/source/src/conversion/autocorrelation_to_composite_sinusoidal_modeling.cc:25:1: error: 'uint64_t' does not name a type
       25 | uint64_t CalculateBinomialCoefficient(int n, int k) {
          | ^~~~~~~~
    /build/source/src/conversion/autocorrelation_to_composite_sinusoidal_modeling.cc:21:1: note: 'uint64_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
       20 | #include <cmath>      // std::acos, std::fabs, std::pow
      +++ |+#include <cstdint>
       21 | #include <cstddef>    // std::size_t
@takenori-y
Copy link
Contributor

Thanks a lot for your kind report.

@takenori-y takenori-y merged commit 732829e into sp-nitech:master Feb 14, 2024
2 checks passed
@trofi trofi deleted the gcc-13-fix branch February 14, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants