Tags: spacedentist/spr
Tags
Release version 1.3.3 This also contains a typo fix in the changelog, plus one extended comment in `diff.rs` that I forgot to save before. Test Plan: `cargo run -- --version`, `cargo package` Reviewers: flooey, jozef-mokry Reviewed By: flooey Pull Request: #92
Fix PullRequestQuery GraphQL query for repositories not owned by orgs GitHub repositories can be owned by users or orgs. The way the PullRequestQuery was phrased it threw an error if the repository used was owned by a user. This commit fixes that. Test Plan: update an existing PR in repositories both owned by a user and an org. Reviewers: jozef-mokry Reviewed By: jozef-mokry Pull Request: #46
Downgrade git2 to fix build with homebrew-installed Rust 1.59 I am setting up a homebrew formula for spr. It depends on Rust, obviously. The homebrew-installed Rust toolchain (currently 1.59) has a problem with the git2 dependency, which I could fix by downgrading it slightly. This commit also bumps the version number for release. Test Plan: `cargo check` I am also using a Docker container (`docker run --rm=true -it homebrew/brew`) to have a clean homebrew set up. With this change, I can use the homebrew-installed Rust to build spr. Reviewers: flooey, jozef-mokry Reviewed By: flooey Pull Request: #42
Fix calculation of base in spr patch command GitHub gives us the oid of the base of a Pull Request, but it doesn't refer to the actual commit that the PR was based on, but the current commit of the branch into which the PR will be merged. So, for a regular PR against master, it gives us current master instead of the commit on master on which the PR is based. That means we have to calculate the base of the branch we create with the `spr patch` command slightly differently. Test Plan: use `spr patch` to look at some older PRs, which are based against older versions of master, and check the created branch. For PRs against master, the new branch should never have a "Base of PR..." commit. Reviewers: jozef-mokry Reviewed By: jozef-mokry Pull Request: #35
PreviousNext