[pull] master from go-shiori:master #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…te (#345) * No more CGO * Update all dependencies to current * Only test against go 1.17.
- Default session duration is 1h - Increased session duration (when remember me is checked) is increased to 30d.
* CI/CD setup * Setup for go-shiori * Fix docker image * Dockerfile adjustments
* feat: async content download when creating via api Invoking the content download code in a goroutine after saving the bookmark, this way we can return a response to the user quickly while the webpage is donwloaded and archived. Cache api endpont (/api/cache) remains untouched until I understand the logic behind it. Also updated the API endpoint for the extension, though I'm unsure why there's a difference between the "regular" API and the webext API, they should be using the same APIs.
It used an update and insert at the same time, since the virtual table cannot have constrants nor upserts we need to try an update the bookmark content to check for it's existence, inserting it only if the update fails (don't affect any rows). This will need to be improved in the future, since not all bookmark updates require modification of the content table (in my case, I was testing only updating tags).
* Fix for infinite redirect loop path.Join trims the trailing slash if the path isn't /, use configured root instead. * Add repo root independence This makes the workflows agnostic of the repository root, making it possible to build in forked repos. * Add HTTP request logging * Fix proper RootPath handler * Add logging for all resources This adds proper logging for all resources, including errors. Logging is on by default, but can be turned off. * Report effective length of written data
* sqlite: remove unneeded LEFT JOIN to improve performance * Fix handling join clause in GetBookmarks * Revert changes in GetBookmarks
- Moved migrations from code to SQL files - Using golang-migrate/v4 - Added a new CLI command: migrate
This commit fixes URL malformation when trying to remove the utm social query parameters from an URL, which upon finishing and reconstructing would attach the equal symbol even if the original URL didn't have it. This is a known Go "bug" [1] that isn't going to be "fixed". I quote that because server side should behave the same for `?a=&b=1` and `?a&b=1` for the `a` parameter, but sometimes that's not the case. [1]: golang/go#20820 Fixes #409
Fixed a bug where the content of the article would archive but the reader version would not be saved due to variable passing. Also made the code easier to follow by following return principles. Fixes #406
* docs: migrate documentation from the wiki * docs: updated docker image url * docs: added migrations section * docs: fixed index link
Fix tiny typo in Wallabag import commands
Co-authored-by: hulb <[email protected]>
Bumps the all group with 3 updates: [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action), [actions/cache](https://github.com/actions/cache) and [codecov/codecov-action](https://github.com/codecov/codecov-action). Updates `golangci/golangci-lint-action` from 6.1.0 to 6.1.1 - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@aaa42aa...971e284) Updates `actions/cache` from 4.0.2 to 4.1.0 - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@0c45773...2cdf405) Updates `codecov/codecov-action` from 4.5.0 to 4.6.0 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@e28ff12...b9fd7d1) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* basic e2e test * e2e ci * test typo * rm go.work * refactor things a bit * use current context for docker image * rm coverage.txt * ignore all coverage files * use package * unused const * simplify dockeringnore * made basic e2e test with cwd code * comments in compose files * fix go version file in e2e ci * experimental podman support * fixed ALPINE_VERSION arg source
* tests: added tests to account domain * refactor: ensure expiration comes from same value * refactor: jwtclaims to model package * refactor: add testutil.GetValidAccount
…er (#992) * feat: build alpine tag alongisde slim tag * fix: warnings in Dockerfile * docs: updated bash reference
* docs: add Mac LaunchAgent instructions Instructions for Mac LaunchAgent so the Shiori server will start at login automatically. * docs: separate sections for macOS start up macOS instruction have its own heading. * docs: rename the heading for Linux start up
* ci: fixed goreleaser version * fix: updated goreleaser configuration * chore: rename arm64_v8.0 binary
* refactor: Migrate documentation to MkDocs with material theme and improved structure * refactor: docs images hierarchy * refactor: Move screenshots to assets and update paths in Screenshots.md * feat: Convert screenshots to MkDocs content tabs with light/dark theme switching * feat: sync content tabs by label * chore: add light theme with shiori red color * docs: Update index page to match README with concise feature list * docs: Remove Resources section from documentation index * ci: added github workflows * docs: Add section for building documentation in Contribute.md
* test: fixed test pointing to removed url file * chore: updated readme screenshots
* feat: Add login component JavaScript file * feat: Create login component and refactor login view * refactor: Convert login to single-page application with dynamic component rendering * feat: Enhance session validation and login form display logic * fix: Resolve Vue app mounting and method duplication issues * fix: Prevent null reference error when focusing username input * fix: Initialize `isLoggedIn` to true to show login form during async check * refactor: Improve session validation and login flow logic * fix: Adjust login component visibility and initial login state * feat: Add login form template to login component * feat: Update login template to match original login.html design * fix: Resolve login view rendering and state management issues * refactor: Remove login route from frontend routes * refactor: Remove login-footer from login component template * fix: Modify logout to show login form without redirecting * refactor: Remove /login route test for SPA architecture * refactor: delete login.html file * style: Remove extra blank line in frontend_test.go * chore: run make style changes
#1022) * fix: Validate session on login component mount to prevent unnecessary login form * fix: Replace non-existent `api/v1/auth/check` with `api/v1/auth/me` * feat: Prevent login form flickering by conditionally rendering only when needed * feat: Show login component after user logout * fix: make styles
Bumps the all group with 8 updates: | Package | From | To | | --- | --- | --- | | [actions/checkout](https://github.com/actions/checkout) | `3.4.0` | `4.2.2` | | [actions/setup-go](https://github.com/actions/setup-go) | `5.0.0` | `5.1.0` | | [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) | `6.0.0` | `6.1.0` | | [actions/upload-artifact](https://github.com/actions/upload-artifact) | `4.4.0` | `4.4.3` | | [actions/setup-python](https://github.com/actions/setup-python) | `4.7.0` | `5.3.0` | | [actions/cache](https://github.com/actions/cache) | `4.1.0` | `4.2.0` | | [codecov/codecov-action](https://github.com/codecov/codecov-action) | `4.6.0` | `5.1.1` | | [cross-platform-actions/action](https://github.com/cross-platform-actions/action) | `0.25.0` | `0.26.0` | Updates `actions/checkout` from 3.4.0 to 4.2.2 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.4.0...11bd719) Updates `actions/setup-go` from 5.0.0 to 5.1.0 - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v5...41dfa10) Updates `goreleaser/goreleaser-action` from 6.0.0 to 6.1.0 - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@286f3b1...9ed2f89) Updates `actions/upload-artifact` from 4.4.0 to 4.4.3 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@5076954...b4b15b8) Updates `actions/setup-python` from 4.7.0 to 5.3.0 - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@61a6322...0b93645) Updates `actions/cache` from 4.1.0 to 4.2.0 - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@2cdf405...1bd1e32) Updates `codecov/codecov-action` from 4.6.0 to 5.1.1 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@b9fd7d1...7f8b4b4) Updates `cross-platform-actions/action` from 0.25.0 to 0.26.0 - [Release notes](https://github.com/cross-platform-actions/action/releases) - [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md) - [Commits](cross-platform-actions/action@cdc9ee6...a0672d7) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major dependency-group: all - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major dependency-group: all - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major dependency-group: all - dependency-name: cross-platform-actions/action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: word check on migration error * refactor: Improve PostgreSQL migration error handling using error codes * refactor: Improve PostgreSQL migration error handling and transaction management * refactor: Remove unused compareWordsInString function and its tests * style: Clean up migrations.go imports and comments * style: Fix gofmt formatting in migrations.go * chore: remove migrations_test file * ci: address golangci-lint warning * test: stop tests if creating database fails * fix: ensure migration transaction is commited or rolled back
* feat: allow disabling swagger ui and disable by default * chore: Add codecov configuration to disable GitHub PR annotations
…1023) * feat: allow import of newer pocket data export files in csv format Signed-off-by: Mel <[email protected]> * fix: linter error Signed-off-by: Mel <[email protected]> --------- Signed-off-by: Mel <[email protected]> Co-authored-by: Felipe Martin <[email protected]>
Bumps the go_modules group with 3 updates: [golang.org/x/crypto](https://github.com/golang/crypto), [golang.org/x/image](https://github.com/golang/image) and [github.com/docker/docker](https://github.com/docker/docker). Updates `golang.org/x/crypto` from 0.23.0 to 0.31.0 - [Commits](golang/crypto@v0.23.0...v0.31.0) Updates `golang.org/x/image` from 0.16.0 to 0.18.0 - [Commits](golang/image@v0.16.0...v0.18.0) Updates `github.com/docker/docker` from 25.0.5+incompatible to 25.0.6+incompatible - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v25.0.5...v25.0.6) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production dependency-group: go_modules - dependency-name: golang.org/x/image dependency-type: direct:production dependency-group: go_modules - dependency-name: github.com/docker/docker dependency-type: indirect dependency-group: go_modules ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* ci: ignore build steps for dependabot prs * ci: Prevent delete-tag job for PRs from forks
…up (#1030) Bumps the all group with 1 update: [actions/setup-go](https://github.com/actions/setup-go). Updates `actions/setup-go` from 5.1.0 to 5.2.0 - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@41dfa10...3041bf5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felipe Martin <[email protected]>
Without this the archive page fails to render.
Bumps the all group with 2 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact) and [codecov/codecov-action](https://github.com/codecov/codecov-action). Updates `actions/upload-artifact` from 4.4.3 to 4.5.0 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@b4b15b8...6f51ac0) Updates `codecov/codecov-action` from 5.1.1 to 5.1.2 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@7f8b4b4...1e68e06) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…it (#1046) * feat: Add nginx service to test shiori webroot configuration chore: Update nginx configuration to resolve 502 gateway error fix: Update SHIORI_WEBROOT to SHIORI_HTTP_ROOT_PATH in docker-compose feat: Add debug log level flag to shiori service refactor: Update docker-compose with simplified command and log configuration fix: Change nginx port mapping from 80 to 8081 feat: Add volume for Go module cache in docker-compose style: Add type attribute to script tags in index.html feat: Update import statements to use RootPath variable in index.html * docs: Update contribution guide with server and docker instructions * docs: Add Docker and nginx documentation for local development * test: IsValid()
* refactor: Improve SQLite performance with connection pooling and retry logic * feat: Add withTx and withTxRetry methods to SQLiteDatabase for handling database locks * refactor: add Init command to all databases * refactor: Improve transaction handling with retry and error management * refactor: Remove panic/recover pattern in transaction handling * refactor: Replace `errors.WithStack` with `fmt.Errorf` in transaction methods * docs: Add docstrings to `withTx` and `withTxRetry` methods in SQLite database implementation * feat: use new withTxRetry in SaveBookmarks * feat: sqlite inmmediate transactions by default * refactor: Split SQLiteDatabase into separate writer and reader dbbase instances * refactor: Update Init method to configure both reader and writer database connections * feat: use writer/reader sqlite databases * refactor: Replace all read calls to use the `reader` database instance * refactor: Replace errors.WithStack with fmt.Errorf and add nil checks refactor: Replace errors.WithStack with fmt.Errorf and add proper error handling fix: Handle potential database connection errors with improved error wrapping refactor: Replace errors.WithStack with fmt.Errorf and improve error handling refactor: Replace error handling with fmt.Errorf and proper nil checks refactor: Replace errors.WithStack with fmt.Errorf and add nil error checks refactor: Replace errors.WithStack with fmt.Errorf and add nil checks in sqlite.go refactor: Replace errors.WithStack with fmt.Errorf and add nil checks refactor: Replace errors.WithStack with fmt.Errorf and improve error handling refactor: Replace remaining errors.WithStack with fmt.Errorf in sqlite.go * refactor: Use withTxRetry for SetDatabaseSchemaVersion method * fix: Simplify error handling in GetBookmark and GetAccount methods * refactor: Remove duplicated non-nil error checks in sqlite.go fix: duplicated non-nil checks * tests: use testutil instead of a manual in memory sqlite db * fix: openbsd sqlite connection
…1050) * test: test all supported engines on their oldest supported releases * update pre-hook file * update mysql container options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )