Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: expand tilde ~/paths in repository paths #1056

Merged
merged 1 commit into from
Jun 22, 2024
Merged

config: expand tilde ~/paths in repository paths #1056

merged 1 commit into from
Jun 22, 2024

Conversation

davvid
Copy link
Collaborator

@davvid davvid commented Jun 20, 2024

No description provided.

jrray
jrray reviewed Jun 20, 2024
View reviewed changes
crates/spfs/src/config.rs Outdated Show resolved Hide resolved
@davvid
Copy link
Collaborator Author

davvid commented Jun 20, 2024

Updates:

  • Now using pub(crate)
  • Renamed to pathbuf_deserialize_with_tilde_expansion

rydrman
rydrman approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@rydrman rydrman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@davvid davvid merged commit 77513d7 into spkenv:main Jun 22, 2024
1 check passed
@davvid davvid deleted the config-paths branch June 22, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrray jrray jrray approved these changes

@rydrman rydrman rydrman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davvid @jrray @rydrman