Skip to content

Commit

Permalink
reverted gemspec changes to limit omniauth requirements
Browse files Browse the repository at this point in the history
  • Loading branch information
@hybridindie
hybridindie committed Aug 8, 2011
1 parent dfc220c commit d9ca5fe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion spree_social.gemspec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ Gem::Specification.new do |s|

s.add_dependency('spree_core', '>= 0.60.0.RC1')
s.add_dependency('spree_auth', '>= 0.60.0.RC1')
s.add_dependency('omniauth', '>= 0.2.6')
s.add_dependency('oa-oauth', '>= 0.2.2') # we don't need all of the omniauth family just the oAuth stuff'

end

4 comments on commit d9ca5fe

@greendog
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, John.
Look what happens if we use oa-oauth instead of the omniauth:
#16 (comment)
If you use omniauth everything works fine.
Also, if we use oa-oauth, authentication does not work via google.

@hybridindie
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we need to just include the gems to make things work properly - Onmiauth as a whole is a pseudo gem (kinda like spree) in the fact it includes a lot. In this case we don't need the bloat that it provides especially the enterprise, ldap, and such. Blogger should work, (can be seen here omniauth / oa-oauth / lib / omniauth / strategies / oauth / blogger.rb ) and you have to use the Google Apps login (their OAuth) i do not have the opened included or supported here.

@hybridindie
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a discrepancy between the strategies included when you include omniauth as a whole (all 24 gems it requires) and just oa-oauth of the same version. This is also causing an issue with the Rails 3.1 and 0.70.99 working versions of Spree and nokogiri requirements. Recommend removing Blogger and Dropbox from the lib/spree_social.rb#OAUTH_PROVIDERS array

@romul
Copy link

@romul romul commented on d9ca5fe Aug 10, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

John is right, use omniauth creates big overhead. But we can consider use oa-oauth 0.2.6

Please sign in to comment.