fix: ZhiPuAiEmbedding supports custom dimensions #3668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YunKui Lu <[email protected]>
|
@mxsl-gr Could you help reviewing this as well? Thank you |
mxsl-gr
approved these changes
Jun 26, 2025
Hi, @ilayaperumalg this PR looks good to me and unit tests passed, feel free to merge @YunKuiLu thanks for the PR |
sunyuhan1998
approved these changes
Jun 26, 2025
|
@mxsl-gr @sunyuhan1998 Thanks for the review! |
|
@YunKuiLu Thanks for the PR! |
spring-builds
pushed a commit
that referenced
this pull request
Jun 26, 2025
Fixes #3668 Signed-off-by: YunKui Lu <[email protected]> (cherry picked from commit 53f8f17)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run the integration tests locally, and everything checks out.