Skip to content

fix: remove unused options from ZhiPu model #3669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -568,16 +568,6 @@ else if (mediaContentData instanceof String text) {
}
}

private ChatOptions buildRequestOptions(ZhiPuAiApi.ChatCompletionRequest request) {
return ChatOptions.builder()
.model(request.model())
.maxTokens(request.maxTokens())
.stopSequences(request.stop())
.temperature(request.temperature())
.topP(request.topP())
.build();
}

public void setObservationConvention(ChatModelObservationConvention observationConvention) {
this.observationConvention = observationConvention;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,6 @@ public class ZhiPuAiChatOptions implements ToolCallingChatOptions {
* provide a list of functions the model may generate JSON inputs for.
*/
private @JsonProperty("tools") List<ZhiPuAiApi.FunctionTool> tools;

private @JsonProperty("tools1") List<ZhiPuAiApi.Foo> foos;

/**
* Controls which (if any) function is called by the model. none means the model will not call a
* function and instead generates a message. auto means the model can pick between generating a message or calling a
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -314,18 +314,6 @@ public String getValue() {
}
}

public class Foo {

String foo;

public Foo() {

}
public Foo(String foo) {
this.foo = foo;
}
}


/**
* Represents a tool the model may call. Currently, only functions are supported as a tool.
Expand Down