Skip to content

Fix the judge bug #3733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TheEterna
Copy link
Contributor

Fixed gh 3729 fixed the incorrect use of class utils.is assignable, This PR fixes that problem.

Signed-off-by: TheEterna <[email protected]>
Copy link
Contributor

@sunyuhan1998 sunyuhan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sobychacko
Copy link
Contributor

Could you pls add a unit test that verifies the changes?

@TheEterna
Copy link
Contributor Author

OK!

Signed-off-by: TheEterna <[email protected]>
@sobychacko
Copy link
Contributor

@TheEterna There are test failures. Run this command: ./mvnw test -Dtest=JsonSchemaGeneratorTests -pl :spring-ai-model and see if it passes for you.

@TheEterna
Copy link
Contributor Author

1751556435478
But I haven't been able to reproduce the failure.

@sobychacko
Copy link
Contributor

It was my bad. All good now. Thanks for confirming.

@sobychacko sobychacko added this to the 1.1.x milestone Jul 3, 2025
@sobychacko sobychacko merged commit cd0cc46 into spring-projects:main Jul 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants