Improve error message when using ResourcelessJobRepository with partitioned steps #4952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tioned steps Issue spring-projects#4732 The ResourcelessJobRepository cannot be used with partitioned steps as it does not support execution context, which is required for partition metadata sharing between manager and worker steps. This commit adds an explicit check in SimpleStepExecutionSplitter to detect usage of ResourcelessJobRepository and throw a clear, informative error message instead of the confusing 'Cannot restart step from STARTING status' message that was previously displayed. Signed-off-by: khj68 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the error message when attempting to use ResourcelessJobRepository with partitioned steps. Previously, users would see a confusing error about 'Cannot restart step from STARTING status' which didn't clearly indicate the actual problem.
Issue
Fixes #4732
Changes
Before
Users would see:
'Cannot restart step from STARTING status. The old execution may still be executing, so you may need to verify manually that this is the case.'
After
Users now see:
'ResourcelessJobRepository cannot be used with partitioned steps as it does not support execution context. Please use a different JobRepository implementation that supports batch meta-data storage for partitioned steps.'
Testing