Skip to content

Don't cache WebSocket request in RequestCache #16741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

yuezk
Copy link
Contributor

@yuezk yuezk commented Mar 16, 2025

The WebSocket connection request should not be cached. Since it doesn't accept a custom header, we cannot use X-Requested-With as the workaround. Instead, we can match the Upgrade: websocket header and ignore it by default.

yuezk added a commit to yuezk/spring-security that referenced this pull request Mar 16, 2025
@yuezk yuezk force-pushed the not_save_websocket_request branch from 2340aeb to 09f8287 Compare March 16, 2025 15:11
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 16, 2025
@yuezk yuezk force-pushed the not_save_websocket_request branch from 09f8287 to e67bd91 Compare March 18, 2025 04:58
@yuezk yuezk changed the title Don't cache WebSocket request Don't cache WebSocket request in RequestCache Mar 22, 2025
@rwinch rwinch self-assigned this Jun 27, 2025
@rwinch rwinch added in: web An issue in web modules (web, webmvc) type: breaks-passivity A change that breaks passivity with the previous release type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 27, 2025
@rwinch rwinch added this to the 7.0.0-M1 milestone Jun 27, 2025
@rwinch rwinch merged commit 7de4217 into spring-projects:main Jun 27, 2025
6 checks passed
@rwinch
Copy link
Member

rwinch commented Jun 27, 2025

Thanks for the Pull Request! This is now merged into main 😄

@yuezk yuezk deleted the not_save_websocket_request branch June 28, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: breaks-passivity A change that breaks passivity with the previous release type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants