PR: Compatibility fixes for Spyder 6.0.0 beta 1 #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the new API after PR spyder-ide/spyder#21844.
Mirror how config dialogs are tested in main Spyder repo for consistency.
As a side-effect of PR spyder-ide/spyder#21734, a QApplication needs to be running before importing spyder.plugins.preferences.widgets.configdialog. Moving the import inside a function achieves this.
* The test that no console was opened did not work because this can be done asynchronously, so instead test for the signal requesting that the console be opened. * The test now only needs the main widget, not the plugin, so move it accordingly.
|
Hello @jitseniesen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-06-17 07:27:27 UTC |
* This is to get Node 20 because older versions are deprecated. * Also replace Replace mambaforge by miniforge now that conda uses the same solver as mamba.
|
I just gave this a try on top of the current 0.5.1 release and it still has one failure: Do you have any clue which patch I am missing to fix this? I'm trying to backport this PR to fix the package in openSUSE Tumblweed. |
You're right, openSUSE is still on Spyder 5.5.4, so the testsuite failures I was hoping to fix with this PR are unrelated. Sorry for the noise. |
Closed
|
I am merging this even though the CI tests do not pass so that I can continue work. I opened an issue so that I don't forget to fix the tests later. |
Before, the Spyder source tree was nested inside the plugin source tree which was messy and may have generated errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits due to changes in Spyder API, change required version, and changes to make the tests run.