Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Moodle and 2FA #6

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

FurTactics
Copy link

@FurTactics FurTactics commented Feb 20, 2024

Hi
I have extended your script due to the introduction of two-factor authentication system and now it has two versions:

  1. It allows you to enter a six digit OTP code on the keyboard, or the 2FA extension does it
  2. It generates the code itself using a secret key, which can be obtained by decrypting the QR code

Also, I often use the e-sprachen Moodle service, so I added an autologin for it as well.
I have a question about the possibility of copyrights and distribution. I'm just starting my way into GitHub and coding and I'm not quite sure what the best thing to do (or the honest and correct thing to do) is: who will distribute the new version of the code? You or me? Or can we do it together?
Anyway, thanks for your development. It helped me a lot!

Best wishes
FurTactics

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
The ability to auto-login in Moodle (foreign language learning platform from LSK MSZ) has been added. The code also waits for a two-factor authentication code to be entered (e.g. as recommended by TUD via the 2FA extension or on the keyboard)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
The ability to auto-login in Moodle (foreign language learning platform from LSK MSZ) has been added. The script also generates a six-digit OTP code by a given key (ONLY FOR GEEKS)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…dditional platforms and 2FA(S)
@FurTactics FurTactics marked this pull request as ready for review April 8, 2024 22:55
@OliEfr

This comment was marked as off-topic.

@FurTactics
Copy link
Author

Hey @OliEfr, yes I know. It's also an interesting project, but I need something with less space and more configurable (I need support for e.g. Moodle). Thanks for your promotion. I'm waiting for an author to release a new version =)

Or you and your command are looking for new developers?😂

@OliEfr

This comment was marked as off-topic.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
… in IDP and notifications.

Now in the Tampermonkey menu you can view click statistics, as well as erase all saved data. A blackout has been added to the IDP website. The configuration site has also been slightly updated and beautiful notifications are now sent.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@spyfly
Copy link
Owner

spyfly commented Jun 18, 2024

Hi @FurTactics, thanks for your contribution.

This PR is not mergable in it's current state.

However I wouldn't mind adding 2FA support (Option #1) and the new features. Feel free to create a new PR where you add yourself in the @author field.

The 2FA Option 2 is a bit more complicated. You've included some copy pasted library code, but that would not be the way to go. It would require adding a build step for the script where an existing library is bundled together with the userscript.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Dark theme was changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants