Added proguard rules to README.MD #513
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bkraszewski Thanks for your interest in SQLCipher. We have been discussing the idea of bundling a ProGuard file within the library itself to help all users instead. Would you have any objection to this? |
|
I think it's a good idea, can we keep info in doc until ProGuard file is ready? |
|
Hi @bkraszewski I have made an adjustment to the ProGuard rules you proposed, and also included some guidance which is now included in the README here. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
I noticed in my release app run app crashed on startup.
The reason was Proguard obfuscation, mentioned in issue: #442
I'd like to mention it in main README.MD to prevent future problems