Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Add validation for JIRA Server field #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yannickoo
Copy link

@yannickoo yannickoo commented Oct 6, 2017

This pull request adds a pattern and title attribute to the JIRA Server field so we can validate it when changing it's value. You can verify the RegEx here – it makes sure the server starts with http:// or https:// + some value after the protocol.

I also thought about using <input type="url"> but this requires more styling so I just added the pattern attribute for validation.

Wrong URL

screen shot 2017-10-06 at 14 49 10

Correct URL

screen shot 2017-10-06 at 14 49 18

This fixes #17 🔨

@iamJoeTaylor
Copy link
Contributor

iamJoeTaylor commented Oct 19, 2017

@yannickoo Thanks for submitting these. I'll try to take a look at these this weekend. It's been 4+ years since I looked at this code so I'll refamiliarize myself with it. Fun fact, my last commits were before I worked at Square, and now I don't work there again. :P

@yannickoo
Copy link
Author

@iamJoeTaylor I also thought this project is abandoned and didn't expect a reaction 😅

I think this extension should be refactored to update the code style etc. but people are still using this extension since it's available on the Chrome Web Store.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIRA Server should required or warn about missing protocol
2 participants