Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building outside of Python environments #18

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Add support for building outside of Python environments #18

merged 1 commit into from
Nov 21, 2023

Conversation

joerowell
Copy link
Contributor

Adds -fPIC to allow building outside of Python environments. Before:

[100%] Linking CXX shared library libMHCUDA.so
/usr/bin/ld: CMakeFiles/MHCUDA.dir/MHCUDA_generated_kernel.cu.o: warning: relocation against `_Z21weighted_minhash_cudaPKfS0_S0_S0_PKjS2_PKiijjPj' in read-only section `.text.startup'
/usr/bin/ld: CMakeFiles/MHCUDA.dir/MHCUDA_generated_kernel.cu.o: relocation R_X86_64_PC32 against symbol `_Z8log_cudajPf' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: bad value
collect2: error: ld returned 1 exit status

After:

[100%] Linking CXX shared library libMHCUDA.so
[100%] Built target MHCUDA

@vmarkovtsev vmarkovtsev merged commit 0500848 into src-d:master Nov 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants