Update Readme #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarkovtsev
requested changes
Jun 2, 2018
README.md
Outdated
| If [numpy](http://www.numpy.org/) headers are not found, | ||
| specify the includes path with defining `NUMPY_INCLUDES`. | ||
| If you do not want to build the Python native module, add `-D DISABLE_PYTHON=y`. | ||
| If CUDA is not automatically found, add `-D CUDA_TOOLKIT_ROOT_DIR=/usr/local/cuda-8.0` | ||
| (change the path to the actual one). | ||
| (change the path to the actual one). | ||
| If you are building from a Docker container you may encounter the error: |
There was a problem hiding this comment.
in a Docker container
the following error
README.md
Outdated
| (change the path to the actual one). | ||
| If you are building from a Docker container you may encounter the error: | ||
| `Could NOT find CUDA (missing: CUDA_TOOLKIT_ROOT_DIR CUDA_INCLUDE_DIRS CUDA_CUDART_LIBRARY)` | ||
| This means need to get the rest of the CUDA toolkit, which can be installed like in the |
There was a problem hiding this comment.
This means you need to install the rest
README.md
Outdated
| This means need to get the rest of the CUDA toolkit, which can be installed like in the | ||
| `nvidia/cuda:8.0-devrel` DockerFile. | ||
| If you still run into `Could NOT find CUDA (missing: CUDA_INCLUDE_DIRS)` then run: | ||
| ```cp /usr/local/cuda/targets/x86_64-linux/include/* /usr/local/cuda/include/``` |
There was a problem hiding this comment.
It is very hacky to copy headers. Use a symbolic link instead
vmarkovtsev
requested changes
Jun 7, 2018
README.md
Outdated
| If you are building in a Docker container you may encounter the following error: | ||
| `Could NOT find CUDA (missing: CUDA_TOOLKIT_ROOT_DIR CUDA_INCLUDE_DIRS CUDA_CUDART_LIBRARY)` | ||
| This means you need to install the rest of the CUDA toolkit, which can be installed like in the | ||
| `nvidia/cuda:8.0-devrel` DockerFile. |
README.md
Outdated
| This means you need to install the rest of the CUDA toolkit, which can be installed like in the | ||
| `nvidia/cuda:8.0-devrel` DockerFile. | ||
| If you still run into `Could NOT find CUDA (missing: CUDA_INCLUDE_DIRS)` then run: | ||
| ```ln -s /usr/local/cuda/targets/x86_64-linux/include/* /usr/local/cuda/include/``` |
There was a problem hiding this comment.
Two whitespaces after ln, should be one
vmarkovtsev
requested changes
Jun 8, 2018
README.md
Outdated
| @@ -33,12 +33,20 @@ Building | |||
| ``` | |||
| cmake -DCMAKE_BUILD_TYPE=Release . && make | |||
| ``` | |||
| It requires cudart, curand >=8.0 and OpenMP 4.0 compatible compiler (**that is, not gcc <=4.8**). | |||
|
|
|||
| It requires cudart, curand 7.5, OpenMP 4.0 compatible compiler (**that is, not gcc <=4.8**) and | |||
There was a problem hiding this comment.
mismerge here: 7.5 vs >=8.0
There was a problem hiding this comment.
ah yeah that one went over my head, changing
Signed-off-by: Romain Keramitas <[email protected]>
vmarkovtsev
approved these changes
Jun 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update to the README file, I lost a couple hours when I was building a Debug version of MinHashCuda for apollo, added it to the company guide here and was prompted by Eiso to also incorporate some of it in the public doc