config: Remove unused max_batch_bytes (cometbft#2050)

This configuration is not used anymore; it's a leftover of batching txs in the mempool, which was deprecated (tendermint/tendermint#5800)
ssrivatsan97 · Jan 17, 2024 · dab72ad · dab72ad
1 parent fd741f5
commit dab72ad
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 14 deletions.
diff --git a/config/config.go b/config/config.go
@@ -885,10 +885,6 @@ type MempoolConfig struct {
  // Maximum size of a single transaction
  // NOTE: the max size of a tx transmitted over the network is {max_tx_bytes}.
  MaxTxBytes int `mapstructure:"max_tx_bytes"`
- // Maximum size of a batch of transactions to send to a peer
- // Including space needed by encoding (one varint per transaction).
- // XXX: Unused due to https://github.com/tendermint/tendermint/issues/5796
- MaxBatchBytes int `mapstructure:"max_batch_bytes"`
  // Experimental parameters to limit gossiping txs to up to the specified number of peers.
  // We use two independent upper values for persistent and non-persistent peers.
  // Unconditional peers are not affected by this feature.

diff --git a/config/toml.go b/config/toml.go
@@ -430,11 +430,6 @@ keep-invalid-txs-in-cache = {{ .Mempool.KeepInvalidTxsInCache }}
 # NOTE: the max size of a tx transmitted over the network is {max_tx_bytes}.
 max_tx_bytes = {{ .Mempool.MaxTxBytes }}
 
-# Maximum size of a batch of transactions to send to a peer
-# Including space needed by encoding (one varint per transaction).
-# XXX: Unused due to https://github.com/tendermint/tendermint/issues/5796
-max_batch_bytes = {{ .Mempool.MaxBatchBytes }}
-
 # Experimental parameters to limit gossiping txs to up to the specified number of peers.
 # We use two independent upper values for persistent and non-persistent peers.
 # Unconditional peers are not affected by this feature.

diff --git a/docs/core/configuration.md b/docs/core/configuration.md
@@ -355,11 +355,6 @@ keep-invalid-txs-in-cache = false
 # NOTE: the max size of a tx transmitted over the network is {max_tx_bytes}.
 max_tx_bytes = 1048576
 
-# Maximum size of a batch of transactions to send to a peer
-# Including space needed by encoding (one `varint` per transaction).
-# XXX: Unused due to https://github.com/tendermint/tendermint/issues/5796
-max_batch_bytes = 0
-
 #######################################################
 ### State Sync Configuration Options ###
 #######################################################