Support go to let, let!, subject, and subject! definitions
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
go-to-definition
branch
from
b982f76 to
4e10a90
Compare
|
Actually, it's not possible to support the right way atm because Ruby LSP's index enhancement doesn't support |
st0012
force-pushed
the
go-to-definition
branch
from
4e10a90 to
f75ddfd
Compare
st0012
force-pushed
the
go-to-definition
branch
from
f75ddfd to
b1ec625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-09-27.at.15.05.26.mov
This is a naive implementation that lists all definitions from the same file.
To better implement this, we need to create the
RSpec::ExampleGroupsclass structures, add the declarations as its methods, and look up the definition based on the example's context.