fix pojo tests with final attributes #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frecco75
commented
Mar 24, 2020
| @@ -46,6 +48,7 @@ private void testSetterAndGetter(final SetterAndFieldPair eachPair, final Object | |||
| private List<SetterAndFieldPair> findSetterAndGetterPairsForFields(final Class<?> testedClass, | |||
| final List<Field> fields) { | |||
| return fields.stream() | |||
| .filter(field -> ! isFinal(field)) | |||
There was a problem hiding this comment.
it depends which PR is merged first.
If support for java 13... we can replace this line by .filter(not(FieldUtils::isFinal))
There was a problem hiding this comment.
i think we still need to test getters, as it was.
setters can be skipped in case of final classes.
There was a problem hiding this comment.
The getter is still tested. We are in the SetterTester class, the object of this pull request is to not test setter method on a final field.
sta-szek
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes pojo tests with final fields. A setter should not be expected on a final field.