Skip to content

Commit

Permalink
Fixing external 404s.
Browse files Browse the repository at this point in the history
  • Loading branch information
dobooth committed Jan 13, 2020
1 parent 04a4335 commit 75f8a37
Show file tree
Hide file tree
Showing 20 changed files with 65 additions and 74 deletions.
2 changes: 1 addition & 1 deletion src/_includes/contributor/labels.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ General labels include a variety of tasks and definitions for pull requests and

Labels applied to issues through verification and completion. For details on the process, see [GitHub Issues Processing Workflow](https://github.com/magento/magento2/wiki/GitHub-Issues-Processing-Workflow).

* `Issue: Format is not valid` - Gate 1 failed. Automatic verification by the Automated Contributor Assistant failed and the issue needs updates. The [format](https://github.com/magento/magento2/tree/2.3-develop/.github/ISSUE_TEMPLATE) of the issue description and minimum required information is not provided: Preconditions, Steps to Reproduce, Actual Result, Expected Result. Previous label `G1 Failed`.
* `Issue: Format is not valid` - Gate 1 failed. Automatic verification by the Automated Contributor Assistant failed and the issue needs updates. The [format](https://github.com/magento/magento2/tree/2.4-develop/.github/ISSUE_TEMPLATE) of the issue description and minimum required information is not provided: Preconditions, Steps to Reproduce, Actual Result, Expected Result. Previous label `G1 Failed`.
* `Issue: Format is valid` - Gate 1 passed. Automatic verification by the Automated Contributor Assistant passed for all issue content. Previous label `G1 Passed`.
* `Issue: Clear Description` - Gate 2 passed. The Community Engineering Team has confirmed that this issue contains the minimum required information to reproduce. Previous label `G2 Passed`.
* `Issue: Cannot Reproduce` - Gate 3 failed. The issue could not be reproduced or validated. Previous label `Cannot Reproduce`.
Expand Down
8 changes: 3 additions & 5 deletions src/cloud/docker/docker-config.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,7 @@ For example, the following command starts the Docker configuration generator for
## Prerequisites

1. You must have the following software installed on your local workstation:
- PHP version 7.1 or later
- [[email protected]](https://formulae.brew.sh/formula/[email protected])
- [[email protected]](https://formulae.brew.sh/formula/[email protected])
- [PHP](https://www.php.net/manual/en/install.php) version 7.1 or later
- [Composer](https://getcomposer.org)
- [Docker](https://www.docker.com/get-started)
- File synchronization required for developer mode—use one of the following:
Expand Down Expand Up @@ -264,9 +262,9 @@ The `{{site.data.var.ct}}` version 2002.0.18 and later supports developer mode.

You can access the local Magento Cloud template by opening one of the following URLs in a browser:

- [`http://magento2.docker`](http://magento2.docker)
- `http://magento2.docker`

- [`https://magento2.docker`](https://magento2.docker)
- `https://magento2.docker`

## Stop and start containers

Expand Down
2 changes: 1 addition & 1 deletion src/cloud/live/go-live-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ The following are recommended changes and checks:

## Performance testing {#performance}

We recommend that you review the [Magento Performance Toolkit]({{ site.mage2bloburl }}/setup/performance-toolkit) options as part of your pre-launch readiness process.
We recommend that you review the [Magento Performance Toolkit](https://github.com/magento/magento2/tree/2.4-develop/setup/performance-toolkit) options as part of your pre-launch readiness process.

You can also test using the following 3rd party options:

Expand Down
2 changes: 1 addition & 1 deletion src/cloud/live/stage-prod-test.md
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ Before launching, we highly recommend performing extensive traffic and performan

Before you begin testing, enter a ticket with support advising the environments you are testing, what tools you are using, and the time frame. Update the ticket with results and information to track performance. When you complete testing, add your updated results and note in the ticket testing is complete with a date and time stamp.

We recommend that you review the [Magento Performance Toolkit]({{ site.mage2bloburl }}/setup/performance-toolkit) options as part of your pre-launch readiness process.
We recommend that you review the [Magento Performance Toolkit](https://github.com/magento/magento2/tree/2.4-develop/setup/performance-toolkit) options as part of your pre-launch readiness process.

For best results, we recommend the following tools:

Expand Down
4 changes: 2 additions & 2 deletions src/guides/v2.3/coding-standards/docblock-standard-general.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ The goal of this standard is to unify usage of code DocBlocks for all files, not

The following is assumed by default:

* Formatting according [phpDocumentor](https://www.phpdoc.org/docs/latest/guides/docblocks.html){:target="_blank"} standard
* Formatting according [phpDocumentor](https://docs.phpdoc.org/latest/references/phpdoc/basic-syntax.html#what-is-a-docblock){:target="_blank"} standard
* Requirements apply for all files regardless of programming language, but a DocBlock standard for the particular language may override it.

## General principles
Expand Down Expand Up @@ -673,7 +673,7 @@ foreach ($errors as $error) {

### @see tag {#see}

Besides the normal way of using `@see` tag as [recommended by phpDocumentor](http://www.phpdoc.org/docs/latest/references/phpdoc/tags/see.html), it may be used as an addition to `@var`, when the `@var` is already used in this comment.
Besides the normal way of using `@see` tag as [recommended by phpDocumentor](https://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.see.pkg.html), it may be used as an addition to `@var`, when the `@var` is already used in this comment.

Specifically, this is possible when a PHP-file composed from multiple file includes, as result variables may contain objects of different types depending on context:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ include note.html
type='info'
content='If Varnish does not start as a service, you must configure SELinux rules to allow it to run. Consult the following resources:

* [flatlinesecurity](http://flatlinesecurity.com/posts/*arnish-4-selinux/)
* [flatlinesecurity](http://flatlinesecurity.com/posts/varnish-4-selinux/)
* [CentOS wiki](https://wiki.centos.org/HowTos/SELinux)
* [CentOS documentation](https://www.centos.org)'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ Lists are useful for organizing and displaying related items. Below are examples

### Images {#images}

Please add any images you may need to the [`common/images`](https://GitHub.com/magento/devdocs/tree/develop/common/images){:target="_blank"} directory.
Please add any images you may need to the [`src/common/images`](https://github.com/magento/devdocs/tree/master/src/common/images) directory.

Once the image is added, you can use it in your documentation:

Expand Down
4 changes: 0 additions & 4 deletions src/guides/v2.3/design-styleguide/iconography/iconography.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,6 @@ Icons should be very descriptive, especially if they stand on their own. Add des

1. Never use an icon without a text (that you may hide). As icons are not read out, we don’t have any hint for a screen reader user what actually is on the screen, an alternative text is important as long as the content doesn’t make sense without an icon at all.

*Source:* Modern Web Accessibility: [Using icon fonts and demystifying speak:none;](http://modernwebaccessibility.com/en/blog/demystify-speak-none)

## Learn More

* yatil.: [The best way to use icon fonts](https://yatil.net/the-best-way-to-use-icon-fonts/)

* Pictos: [Using Icon Fonts](http://pictos.cc/articles/using-icon-fonts/)
2 changes: 1 addition & 1 deletion src/guides/v2.3/extension-dev-guide/plugins.md
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ class MyUtilityUpdater

The `sortOrder` property from the `plugin` node declared in `di.xml` determines the plugin's prioritization when more than one plugin is observing the same method.

The [`Magento\Framework\Interception\PluginListInterface`]({{ site.mage2bloburl }}/{{ page.guide_version }}/lib/internal/Magento/Framework/Interception/PluginListInterface.php) which is implemented by [`Magento\Framework\Interception\PluginList\PluginList`]({{ site.mage2bloburl }}/{{ page.guide_version }}/lib/internal/Magento/Framework/Interception/PluginList\PluginList.php) is responsible to define when to call the before, around, or after methods respecting this prioritization.
The [`Magento\Framework\Interception\PluginListInterface`]({{ site.mage2bloburl }}/{{ page.guide_version }}/lib/internal/Magento/Framework/Interception/PluginListInterface.php) which is implemented by [`Magento\Framework\Interception\PluginList\PluginList`](https://github.com/magento/magento2/blob/2.3/lib/internal/Magento/Framework/Interception/PluginList/PluginList.php) is responsible to define when to call the before, around, or after methods respecting this prioritization.

If two or more plugins have the same `sortOrder` value or do not specify it, the [component load order]({{ page.baseurl }}/extension-dev-guide/build/module-load-order.html) declared in the `sequence` node from `module.xml` and [area]({{ page.baseurl}}/extension-dev-guide/build/di-xml-file.html#areas-and-application-entry-points) will define the merge sequence. Check the component load order in `app/etc/config.php` file.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,6 @@ it will resolve to “John”.

<!-- Link Definitions -->
[Insert Variable]: https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/templates/template-email.html#customize-content
[New Order email template]: https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Sales/view/frontend/email/order_new.html
[model]: https://github.com/magento/magento2ce/blob/2.3-develop/app/code/Magento/Sales/Model/Order/Email/Sender/InvoiceSender.php
[1]: https://github.com/magento/magento2ce/blob/2.3-develop/app/code/Magento/Email/Model/AbstractTemplate.php
[New Order email template]: https://github.com/magento/magento2/blob/2.3/app/code/Magento/Sales/view/frontend/email/order_new.html
[model]: https://github.com/magento/magento2ce/blob/2.3/app/code/Magento/Sales/Model/Order/Email/Sender/InvoiceSender.php
[1]: https://github.com/magento/magento2ce/blob/2.3/app/code/Magento/Email/Model/AbstractTemplate.php
Loading

0 comments on commit 75f8a37

Please sign in to comment.