fix deprecated QDateTime warning ctor with Qt 6.8 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyy32
reviewed
Oct 18, 2024
|
Please also replace what @sergeyy32 commented on, plus, there are a few usages in qztest that still emit a warning. Also, consider Otherwise lgtm. |
since Qt 6.8 constructor of QDateTime, which accepts TimeSpec enum, marked as deprecated. to compile at this version of Qt it necessary to explicitly pass QTimeZone instead. to save work with lower version of Qt, version check macro was added. it is critical to code where warnings treats as errors. issue: #207
pradlol
force-pushed
the
fix_build_with_qt_68
branch
from
212427f to
d272d43
Compare
|
@cen1, @sergeyy32, thanks for review. fixed your comments. there is another small question indirectly related to this PR: the readme mentions Qt4, is it still supported? just as far as I can see, Qt4 doesn't have QTimeZone class, and the test code in the develop branch uses it. |
|
Looking good. Qt4 is most likely broken at this point in time.
Considering all active projects are transitioning from Qt5 to Qt6 and there is only legacy software using Qt4 (which can simply use an old quazip release) the most likely result will be that Qt4 will be removed as supported version in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change fix compilation warnings with Qt version 6.8
issue: #207