Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useless-vec warnings throughout stackslib #5629

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Fix useless-vec warnings throughout stackslib #5629

wants to merge 6 commits into from

Conversation

jferrant
Copy link
Collaborator

No description provided.

@jferrant jferrant requested a review from a team as a code owner December 31, 2024 20:22
jbencin
jbencin reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@jbencin jbencin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should result in some performance gains by reducing Vec allocations. Just address the comments I made and I'll approve

obycode
obycode previously approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jcnelson
jcnelson previously approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just be sure to address @jbencin's comments about directly passing a Vec<..> when the callee needs an owned copy of the data.

@jferrant jferrant dismissed stale reviews from jcnelson and obycode via 14a3dab January 2, 2025 23:13
obycode
obycode previously approved these changes Jan 3, 2025
View reviewed changes
@jferrant jferrant requested a review from obycode January 3, 2025 17:20
obycode
obycode previously approved these changes Jan 3, 2025
View reviewed changes
jbencin
jbencin previously approved these changes Jan 3, 2025
View reviewed changes
@jferrant jferrant enabled auto-merge January 3, 2025 17:59
@jferrant jferrant added this pull request to the merge queue Jan 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 3, 2025
@jferrant jferrant dismissed stale reviews from jbencin and obycode via dda5463 January 4, 2025 01:35
@jferrant jferrant requested review from jbencin and obycode January 4, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hstove hstove Awaiting requested review from hstove

@jcnelson jcnelson Awaiting requested review from jcnelson

@jbencin jbencin Awaiting requested review from jbencin

@obycode obycode Awaiting requested review from obycode

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jferrant @jcnelson @obycode @jbencin