-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: starting point for course snapping #219
Conversation
Archdoog
commented
Sep 5, 2024
•
edited
Loading
edited
- Adds course snapping functionality for user location.
android/core/src/main/java/com/stadiamaps/ferrostar/core/NavigationViewModel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed some fixes which should address the worst issues. I think this should un-block you from continuing :)
One unit test will still fail, but that is to be expected, since we're unconditionally snapping the course (which should be configurable).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super close now! I think all of my remaining feedback is around how to name things ;)
We can also discuss during tomorrow's meeting how this relates to #250. I saw your comments about putting the raw location in TripState
and while I don't think that's the right move, it's possible that maybe I'm missing some other organization that works better. Both this and the other PR are concerned with filtering/processing location, and so maybe there is something general that we should be organizing both under (paving the way for things like Kalman filtering with a more formal structure than, for example, wrapping it in a location provider). It's tricky because some of these are very specific to a current trip whereas others (ex: raw location, Kalman filtering, other techniques for removing GPS noise, etc.) are more independent.
Note to self before final merge: verify that this doesn't break anything on the web components; those are not covered as well by automated tests. |
This is perfect! I just took a screen recording of driving while the navigation mode was bicycle (to force some off route). It tracked the heading perfectly (even when going the exact wrong direction at the start). trim.BDCCDD56-A087-44DD-A973-0F80FE806F1A.MOV |