Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web cleanup #249

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Web cleanup #249

merged 5 commits into from
Sep 17, 2024

Conversation

ianthetechie
Copy link
Contributor

@ianthetechie ianthetechie commented Sep 14, 2024

This is another round of web improvements.

  • Adds hooks for configuring the map on first load.
  • Automatically adds a MapLibre GeolocateControl, which is the UI that most people will want/expect. By default, it will automatically trigger location updates on load, but this can be easily disabled.
  • Removes the stand-in marker that tracked the user location except during simulation (where there is no alternative; the GeolocateControl doesn't have a swappable location engine as on mobile).
  • Removes the Stadia Maps autocomplete search control, but retains it in the demo app. This is extremely useful, and adding it directly was the quickest path to getting something actually usable+testable over the summer, but now we can remove the tight linkage thanks to other improvements in this PR. The dev dependency is upgraded to the latest version, which has a lot of visual improvements (see Layout fixes maplibre-search-box#4)
  • Adds hooks for supplying custom CSS (needed due to the way Lit's scoped shadow DOM works in order to properly style things like MapLibre plugins).

Closes #206. Closes #207.

Copy link
Collaborator

@Archdoog Archdoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved during ferrostar call 8/16/24

Package.swift Outdated Show resolved Hide resolved
@ianthetechie ianthetechie merged commit 108cfa1 into main Sep 17, 2024
12 checks passed
@ianthetechie ianthetechie deleted the web-cleanup branch September 17, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants