Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Allow distributions to return vectors #2751

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

[WIP] Allow distributions to return vectors #2751

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0890920
adds internals needed for supporting vector returning lpdfs
SteveBronder May 26, 2022
d888a0f
get vector working for prim and reverse mode
SteveBronder May 26, 2022
793b4f8
prototype reducer to allow distributions to return vectors instead of…
SteveBronder Jun 3, 2022
f7b6c3d
clang format
SteveBronder Jun 3, 2022
31db2e4
Merge commit '8f50d1539f93ae073518bfd5b6512e5069b7b339' into HEAD
yashikno Jun 3, 2022
5a0c081
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Jun 3, 2022
bb1918c
remove unneeded constructors from prob_reducer
SteveBronder Jun 3, 2022
704533f
fix normal lpdf test names
SteveBronder Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix normal lpdf test names
  • Loading branch information
@SteveBronder
SteveBronder committed Jul 8, 2022
commit 704533f1b6562ccb864306c806d2d9598f16682d
2 changes: 1 addition & 1 deletion stan/math/prim/prob/normal_lpdf.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ inline auto normal_lpdf(const T_y& y, const T_loc& mu, const T_scale& sigma) {
}
if (include_summand<propto, T_scale>::value) {
if (RetType == ProbReturnType::Scalar) {
logp -= sum(log(sigma_val)) * N / size(sigma);
logp -= sum(log(sigma_val)) * N / math::size(sigma);
} else {
logp -= log(sigma_val);
}
Expand Down
4 changes: 2 additions & 2 deletions test/unit/math/rev/prob/normal_log_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include <stan/math/rev.hpp>
#include <gtest/gtest.h>

TEST(ProbDistributionsNormal, intVsDouble) {
TEST(ProbDistributionsNormal, intVsDoublerev) {
using stan::math::var;
for (double thetaval = -5.0; thetaval < 6.0; thetaval += 0.5) {
var theta(thetaval);
Expand All @@ -22,7 +22,7 @@ TEST(ProbDistributionsNormal, intVsDouble) {
}
}

TEST(ProbNormal, test_vlpdf) {
TEST(ProbNormal, test_vlpdf_rev) {
using stan::math::var;
Eigen::Matrix<var, -1, 1> Y = Eigen::Matrix<double, -1, 1>::Random(5);
Eigen::Matrix<var, -1, 1> Mu = Eigen::Matrix<double, -1, 1>::Random(5);
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.