Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MedAlign scenario #3038

Merged
merged 7 commits into from
Dec 20, 2024
Merged

Add MedAlign scenario #3038

merged 7 commits into from
Dec 20, 2024

Conversation

aunell
Copy link
Contributor

@aunell aunell commented Oct 2, 2024

Initial implementation of MedAlign functionality

@yifanmai
Copy link
Collaborator

The current implementation is a bit hacky regarding the custom Adapter and Input. I would be fine with merging this immediately if urgently needed, with the expectation that we might make breaking changes to undo the hacks. Otherwise, I'd like some time to think about how to implement this more cleanly.

This was referenced Oct 10, 2024
Closed
Open
yifanmai
yifanmai approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@yifanmai yifanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this because I will be out for a while. Will do post-merge review eventually.

@yifanmai yifanmai changed the title Medhelm Add MedAlign scenario Dec 20, 2024
@yifanmai yifanmai merged commit 5e9bf74 into main Dec 20, 2024
11 checks passed
@yifanmai yifanmai deleted the medhelm branch December 20, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yifanmai yifanmai yifanmai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aunell @yifanmai