Add multiple annotators to Omni-MATH and rename shared modules #3291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifanmai
requested changes
Jan 23, 2025
| if len(all_judgements) == 0: | ||
| raise ValueError("Could not compute Omni-MATH accuracy because all annotators failed.") | ||
| judgement_bools = [judgement.strip().upper() == "TRUE" for judgement in all_judgements] | ||
| score = sum(judgement_bools) / len(judgement_bools) |
There was a problem hiding this comment.
It's not valid to sum an array of bools, right? You need to cast them to int first.
There was a problem hiding this comment.
I think bool is a subclass of int in Python, so it actually works fine..? If that introduces too much ambiguity I can go with explicit casting for sure.
>>> sum([True, False])
1
>>> issubclass(bool, int)
True
Comment on lines
+86
to
+87
| if equivalence_judgement == "": | ||
| continue # skip this annotator if there is no equivalence judgement parsed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.