forked from corpetty/py-etherscan-api
-
Notifications
You must be signed in to change notification settings - Fork 0
Sync with the most recent version #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
starlure
wants to merge
26
commits into
starlure:jasonw
Choose a base branch
from
corpetty:master
base: jasonw
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tox enforces linting on etherscan folder
prefix constant in Client class changed to https://api-ropsten.etherscan.io/api?
readme was updated with https://ropsten.etherscan.io/apis for use with ropsten testnet
Cleaned up code to comply with flake8 linter
Created client.ropsten.py. Merged despite comment from @AndreMiras, this can be refactored, rather have the functionality first. I do agree that your solution was an easier method.
https://nvd.nist.gov/vuln/detail/CVE-2018-18074 Also uses greater than, rather than pinning exact version.
Fixes unit tests and linting
Updates requests dependency (security)
Proxies module additions
Add test set up to ignore the annoying requests test warning. Add logs modules and test case. Add module gas tracker and test case. Add api key error. Modified README file. Modified setup.py file version.
Add two modules and test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.