Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(analytics): Allow analytics to be configured per env #21975

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ilmotta
Copy link
Contributor

@ilmotta ilmotta commented Jan 22, 2025

Fixes #21974

Summary

Allows MixPanel to be configured per environment. The hardcoded MixPanel app ID and token are removed from the code (see the parent issue for more details). The token can be exploited and that's by design in analytics tools https://developer.mixpanel.com/reference/project-token, but we are being too kind at the same time, so I'm removing that from code ;)

Areas that may be impacted

  • Analytics

Steps to test

I will test this PR myself.

  • Enable usage data during onboarding and from settings.
  • Check the events are published to the correct MixPanel project.

Note: to test the correct values are set-up in Jenkins for release builds we need to generate a release build. That's the reason I committed a change to the VERSION file with the PR number, as I believe this is the recommendation from infra team.

status: ready

@ilmotta ilmotta added the infra label Jan 22, 2025
@ilmotta ilmotta self-assigned this Jan 22, 2025
@ilmotta ilmotta requested review from siddarthkay and a team January 22, 2025 15:27
@ilmotta ilmotta force-pushed the ilmotta/configure-mixpanel-per-env branch from 7d89cf6 to 61bf682 Compare January 22, 2025 15:28
@status-im-auto
Copy link
Member

status-im-auto commented Jan 22, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 61bf682 #3 2025-01-22 15:34:15 ~5 min tests 📄log
✔️ 61bf682 #3 2025-01-22 15:38:11 ~9 min android-e2e 🤖apk 📲
✔️ 61bf682 #3 2025-01-22 15:39:06 ~10 min android 🤖apk 📲
✔️ 61bf682 #3 2025-01-22 15:41:07 ~12 min ios 📱ipa 📲

@ilmotta
Copy link
Contributor Author

ilmotta commented Jan 22, 2025

Thanks for the swift reviews guys!


@siddarthkay I tagged you as a reviewer to help us configure the vars in Jenkins. The shadow-cljs code already allows passing the vars to the initialization code in status-go, so I believe it's just a matter of passing down the vars from Jenkins. The parent issue has the details about what we expect to be configured #21974 in Jenkins. When the time is appropriate for you, could you help us by adding the vars to Jenkins? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: REVIEW
Development

Successfully merging this pull request may close these issues.

Segregate centralized analytics per environment
5 participants