Skip to content

Conversation

Payal-Goswami
Copy link
Contributor

Resolves #8129.

Description

This pull request fixes several linting errors flagged by ESLint:

  • lib/node_modules/@stdlib/_tools/github/create-repo/lib/factory.js

    Moved done function to the outer scope.

  • lib/node_modules/@stdlib/assert/is-method/examples/index.js

    Removed extra spaces near object/array brackets (auto-fixed with eslint --fix).

  • lib/node_modules/@stdlib/ndarray/base/shape2strides/benchmark/benchmark.js

Added // eslint-disable-next-line stdlib/no-new-array to handle new Array() in generated benchmark code.

Related Issues

This pull request:

Questions

No.

Other

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Sep 23, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Sep 23, 2025

Coverage Report

Package Statements Branches Functions Lines
assert/is-method $\color{green}104/104$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}104/104$
$\color{green}+100.00\%$
ndarray/base/shape2strides $\color{green}255/255$
$\color{green}+100.00\%$
$\color{green}16/16$
$\color{green}+100.00\%$
$\color{green}6/6$
$\color{green}+100.00\%$
$\color{green}255/255$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Sep 24, 2025
kgryte
kgryte previously approved these changes Sep 24, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Sep 24, 2025
@kgryte kgryte merged commit 4dba8a6 into stdlib-js:develop Sep 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors
3 participants