Fixed bad right bitshift >> to >>>

stea4lth · Oct 5, 2016 · 22c7e26 · 22c7e26
1 parent 58e5ec7
commit 22c7e26
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 9 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,4 +1,10 @@
 
+v0.24.30
+--------
+
+Fixed bad right bitshift >> to >>>
+
+
 v0.24.28 - v0.24.29
 -------------------
 

diff --git a/lib/ScreenBuffer.js b/lib/ScreenBuffer.js
@@ -980,7 +980,7 @@ ScreenBuffer.attr2object = function attr2object( attr )
 	var object = {} ;
 
 	object.color = attr & 255 ;
-	object.bgColor = ( attr >> 8 ) & 255 ;
+	object.bgColor = ( attr >>> 8 ) & 255 ;
 
 	// Style part
 	if ( attr & ScreenBuffer.BOLD ) { object.bold = true ; }
@@ -1049,7 +1049,7 @@ ScreenBuffer.object2attr = function object2attr( object )
 ScreenBuffer.generateEscapeSequence = function generateEscapeSequence( term , attr )
 {
 	var color = attr & 255 ;
-	var bgColor = ( attr >> 8 ) & 255 ;
+	var bgColor = ( attr >>> 8 ) & 255 ;
 
 	var esc = term.optimized.styleReset +
 		term.optimized.color256[ color ] +
@@ -1079,8 +1079,8 @@ ScreenBuffer.generateDeltaEscapeSequence = function generateDeltaEscapeSequence(
 	var esc = '' ,
 		color = attr & 255 ,
 		lastColor = lastAttr & 255 ,
-		bgColor = ( attr >> 8 ) & 255 ,
-		lastBgColor = ( lastAttr >> 8 ) & 255 ;
+		bgColor = ( attr >>> 8 ) & 255 ,
+		lastBgColor = ( lastAttr >>> 8 ) & 255 ;
 
 	// Bold and dim style are particular: all terminal has noBold = noDim
 

diff --git a/lib/TextBuffer.js b/lib/TextBuffer.js
@@ -1095,7 +1095,7 @@ function blitterLineIterator( p )
 		attr = attrs[ srcX ] ;
 
 		// Write the attributes
-		p.context.dstBuffer.writeUInt32BE( attr , dstOffset ) ;
+		p.context.dstBuffer.writeInt32BE( attr , dstOffset ) ;
 
 		charCode = str.charCodeAt( srcX ) ;
 
@@ -1117,7 +1117,7 @@ function blitterLineIterator( p )
 	for ( ; srcX <= p.srcXmax ; srcX ++ , dstOffset += ScreenBuffer.ITEM_SIZE )
 	{
 		// Write the attributes
-		p.context.dstBuffer.writeUInt32BE( attr , dstOffset ) ;
+		p.context.dstBuffer.writeInt32BE( attr , dstOffset ) ;
 
 		// Write the character
 		p.context.dstBuffer.write( ' ' , dstOffset + ScreenBuffer.ATTR_SIZE , ScreenBuffer.CHAR_SIZE ) ;
@@ -1150,7 +1150,7 @@ function blitterHiddenLineIterator( p )
 		attr = attrs[ srcX ] ;
 
 		// Write the attributes
-		p.context.dstBuffer.writeUInt32BE( attr , dstOffset ) ;
+		p.context.dstBuffer.writeInt32BE( attr , dstOffset ) ;
 
 		// Write the character
 		p.context.dstBuffer.write( char , dstOffset + ScreenBuffer.ATTR_SIZE , ScreenBuffer.CHAR_SIZE ) ;
@@ -1162,7 +1162,7 @@ function blitterHiddenLineIterator( p )
 	for ( ; srcX <= p.srcXmax ; srcX ++ , dstOffset += ScreenBuffer.ITEM_SIZE )
 	{
 		// Write the attributes
-		p.context.dstBuffer.writeUInt32BE( attr , dstOffset ) ;
+		p.context.dstBuffer.writeInt32BE( attr , dstOffset ) ;
 
 		// Write the character
 		p.context.dstBuffer.write( ' ' , dstOffset + ScreenBuffer.ATTR_SIZE , ScreenBuffer.CHAR_SIZE ) ;

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "terminal-kit",
-  "version": "0.24.29",
+  "version": "0.24.30",
   "description": "256 colors, keys and mouse, input field, screen buffer, interactive 'yes or no', and many more... Whether you just need colors and styles, build a simple interactive command line tool or a complexe terminal app: this is the absolute terminal lib for Node.js!",
   "main": "lib/termkit.js",
   "directories": {