Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pvHttp.cpp: fix for "batt" not being read and inverting its value #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joschro
Copy link

@joschro joschro commented Sep 26, 2024

  • the else statement was missing for the cfgPvHttpJsonBatt section, therefore "batt" would only have been evaluated if the parameter was missing in the config...
  • Sonnenbatterie reports energy flowing into the batterie (charging) as positive values ("Pac_total_W") while energy flowing into the grid is a positive number ("GridFeedIn_W"). To make sure we give charging the car priority before charging the battery from PV, but also charge the car from PV in case the battery is already full, we need to invert the "batt" value and then add it to "watt".

- the else statement was missing for the cfgPvHttpJsonBatt section, therefore "batt" would only have been evaluated if the parameter was missing in the config...
- Sonnenbatterie reports energy flowing into the batterie (charging) as positive values ("Pac_total_W") while energy flowing into the grid is a positive number ("GridFeedIn_W"). To make sure we give charging the car priority before charging the battery from PV, but also charge the car from PV in case the battery is already full, we need to invert the "batt" value and then add it to "watt".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant