-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update_pose() API call #79
Add update_pose() API call #79
Conversation
The solution has been verified by calling The verification patch looks like follows:
There are two cases were checked: |
@AlexeyMerzlyakov Is this a draft? |
There are some changes might be applied later, when |
@ymd-stella , @SteveMacenski Thank you for attentive review! Most of the comments I agree with and will make a next patch meeting the review items in next update. |
b28a597
to
337d89e
Compare
Made a force-push update (there were code refactoring conflicts) with review items met. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
I have written some comments, please have a look.
Co-authored-by: ymd-stella <[email protected]>
Okay, I've made next push. There were met all second review items & applied clang-format on changed files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's getting very good. Thank you for your contribution. There are still a few things that annoy me, so let me discuss them.
Adding new
system.h/system.cc
API call for updating camera position by known pose. This is a part required for stella-cv/stella_vslam_ros#11 ticket to add the support of the/initialpose
intentionally set by developer.