Initial fix for reneg issue

- see bcgit/bc-java#990
stephanadler1 · Jul 26, 2021 · 0bb8330 · 0bb8330
1 parent d8187de
commit 0bb8330
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/crypto/src/tls/AbstractTlsContext.cs b/crypto/src/tls/AbstractTlsContext.cs
@@ -94,6 +94,11 @@ internal bool IsConnected
             get { lock (this) return m_connected; }
         }
 
+        internal bool IsHandshaking
+        {
+            get { lock (this) return !m_connected && null != m_securityParameters; }
+        }
+
         public TlsCrypto Crypto
         {
             get { return m_crypto; }

diff --git a/crypto/src/tls/TlsProtocol.cs b/crypto/src/tls/TlsProtocol.cs
@@ -401,7 +401,7 @@ protected virtual void CompleteHandshake()
                 AbstractTlsContext context = ContextAdmin;
                 SecurityParameters securityParameters = context.SecurityParameters;
 
-                if (m_appDataReady ||
+                if (!context.IsHandshaking ||
                     null == securityParameters.LocalVerifyData ||
                     null == securityParameters.PeerVerifyData)
                 {
@@ -1557,6 +1557,19 @@ public virtual bool IsClosed
             get { return m_closed; }
         }
 
+        public virtual bool IsConnected
+        {
+            get
+            {
+                if (m_closed)
+                    return false;
+
+                AbstractTlsContext context = ContextAdmin;
+
+                return null != context && context.IsConnected;
+            }
+        }
+
         public virtual bool IsHandshaking
         {
             get
@@ -1566,7 +1579,7 @@ public virtual bool IsHandshaking
 
                 AbstractTlsContext context = ContextAdmin;
 
-                return null != context && !context.IsConnected;
+                return null != context && context.IsHandshaking;
             }
         }