Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions to global mode #9

Merged
merged 1 commit into from
Jun 24, 2016
Merged

Exceptions to global mode #9

merged 1 commit into from
Jun 24, 2016

Conversation

mattiasb
Copy link
Contributor

Make it possible to define a list of modes that shouldn't have
control-mode enabled when running global-control-mode.

Useful for modes like dired and magit that already have a bunch of
single-key keybindings defined.

Make it possible to define a list of modes that shouldn't have
`control-mode` enabled when running `global-control-mode`.

Useful for modes like `dired` and `magit` that already have a bunch of
single-key keybindings defined.
:group 'control
:type '(repeat (function))
:set (lambda (x v)
(setq global-control-mode-exceptions v)))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could avoid this setter by just adding the defcustom where the defvar is now. But given how you do it for the other defcustom I guess you want it this way?

@mattiasb
Copy link
Contributor Author

Ping? :)

@mrkkrp
Copy link
Contributor

mrkkrp commented Jun 24, 2016

Shameless plug: try Modalka perhaps? BTW, in the README.md file you will find overview of all such packages in existence.

@stephendavidmarsh stephendavidmarsh merged commit 6bf4871 into stephendavidmarsh:master Jun 24, 2016
@stephendavidmarsh
Copy link
Owner

Not sure how I missed this pull request. This functionality probably deserves a section in the README.md, but that can come later.

@mattiasb
Copy link
Contributor Author

@stephendavidmarsh I'll write something up today!

@mattiasb mattiasb deleted the global-exceptions branch June 24, 2016 19:18
@mattiasb
Copy link
Contributor Author

@mrkkrp with modalka you have to add all modal keybindings manually from the looks of it. That's not something I'm particularly interested in. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants