Skip to content

Commit

Permalink
allow renaming of json serialization related things
Browse files Browse the repository at this point in the history
Summary:
After D3983103 and D4246140 we can rename Foo <-> FooSerializer <-> FooDeserializer related classes.

One class that's a hold out to the various machinery that allows this is FeedUnit and its serdes. So, blacklist them specifically in proguard.

Reviewed By: int3

Differential Revision: D4326199

fbshipit-source-id: 492e1975814a4e0936c4906f92fd2f7f6c7d3292
  • Loading branch information
Brian Long authored and facebook-github-bot committed Dec 28, 2016
1 parent 0587873 commit f3a9973
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions opt/renameclasses/RenameClassesV2.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -585,13 +585,13 @@ void RenameClassesPassV2::eval_classes(
continue;
}

if (dont_rename_serde_relationships.count(clazz->get_type()) > 0) {
m_dont_rename_reasons[clazz] = { DontRenameReasonCode::SerdeRelationships, norule };
if (!can_rename_if_ignoring_blanket_keep(clazz)) {
m_dont_rename_reasons[clazz] = { DontRenameReasonCode::ProguardCantRename, norule };
continue;
}

if (!can_rename_if_ignoring_blanket_keep(clazz)) {
m_dont_rename_reasons[clazz] = { DontRenameReasonCode::ProguardCantRename, norule };
if (dont_rename_serde_relationships.count(clazz->get_type()) > 0) {
m_dont_rename_reasons[clazz] = { DontRenameReasonCode::SerdeRelationships, norule };
continue;
}
}
Expand Down

0 comments on commit f3a9973

Please sign in to comment.