Another try at stopping Federation_ReloadOfMetadata_KeepsOldDataUntil…

…MetadataBecomesInvalid from breaking the build

Tests/Tests.Shared/FederationTests.cs

@@ -292,14 +292,14 @@ public void Federation_ReloadOfMetadata_KeepsOldDataUntilMetadataBecomesInvalid(
                 // Wait until a failed load has occured.
                 SpinWaiter.While(() => subject.LastMetadataLoadException == null,
                     "Timeout passed without a failed metadata reload.");
+
+                subject.MetadataValidUntil.Should().NotBe(DateTime.MinValue);
             }
             catch(AssertFailedException)
             {
                 Assert.Inconclusive("This test is sensitive to race conditions, didn't work this time. Don't worry.");
             }
 
-            subject.MetadataValidUntil.Should().NotBe(DateTime.MinValue);
-
             options.IdentityProviders.TryGetValue(new EntityId("http://idp1.federation.example.com/metadata"), out idp)
                 .Should().BeTrue("idp shouldn't be removed while metadata is still valid.");