This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
adds estimated_delivery_at #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,7 +29,7 @@ class TrackingInformation | |||
| } | |||
|
|
|||
| attr_reader :tracking_number, :signature_name, :service_type, :status, | |||
| :delivery_at, :events, :unique_tracking_number | |||
| :delivery_at, :events, :unique_tracking_number, :estimated_delivery_at | |||
There was a problem hiding this comment.
I don't actually see estimated_delivery_at used anywhere in the fashionthing PR. It's using estimated_delivery_timestamp
There was a problem hiding this comment.
i told you this already but for the purposes of documentation:
i am replacing this line https://github.com/stitchfix/fashionthing/pull/980/files#diff-f7a570d3dfca86b346de504a175b2eceR33 with tracking_data.estimated_delivery_at.try(:to_date)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this PR in FashionThing, I added an
estimated_delivery_atvariable that can be accessed from the Fedex::TrackingInformation class.I can't get all the specs in lib/fedex/track_spec.rb to pass though so not sure if I need to do anything special.
@davetron5000 @jonathandean