remove reference to Fixnum (removed in Ruby 3.2) #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugs.ruby-lang.org/issues/12005 Bump Ruby requirement to 2.4+ accordingly.
zackse
force-pushed
the
ez/ruby-3.2-support
branch
from
9e37d38 to
820f456
Compare
ebarendt
requested changes
Nov 11, 2022
zackse
force-pushed
the
ez/ruby-3.2-support
branch
from
71368e8 to
e071985
Compare
ebarendt
approved these changes
Nov 11, 2022
ebarendt
reviewed
Dec 7, 2022
| @@ -179,9 +174,9 @@ def load(params) | |||
| # `load` is the behavior we want (in later versions, `load` uses `safe_load`, which doesn't support aliases and | |||
| # requires allowlisting classes used in files. | |||
| if Psych::VERSION < '3.3.2' | |||
There was a problem hiding this comment.
what version of Psych comes with Ruby 2.4?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Fixnumis removed from Ruby 3.2+File.exists?is removed from Ruby 3.2+Solution
File.exists?withFile.exist?