-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3 support #5
Conversation
Thanks for the PR @jni! The way the extension was previously installed was rather hacky, so this is a good opportunity to change that. The issue is the javascript component of the extension. The current setup copies the javascript directly to the jupyter extensions directory (outside the package wheel) because I didn't figure any other good way to seamlessly install it programmatically, but this workaround was never really ideal (and indeed the current hack seems to not work at all in python 3), so I'll work on a different approach. |
@kzielnicki great, thanks! @Carreau pointed me to this page for the latest docs on installing Jupyter extensions: |
I can try to review and give extra comments (this week will tough though). The best would be to copy / get inspiration from jupyterlab as they are just an extension of the notebook server. I would also have a look at the fantastic work the Jupyter_Contrib folks are doing as they have an extension to install/uninstall other extensions. |
Hi @kzielnicki! Thanks for nodebook, it's a great idea!
I think this should cover Python 3 support, but the installation of the notebook extension isn't working on IPython 6.x. Probably something needs to change in the install procedure that I haven't figured out yet.
Fixes #4.