Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3 support #5

Merged
merged 8 commits into from
Oct 17, 2017
Merged

Add Python 3 support #5

merged 8 commits into from
Oct 17, 2017

Conversation

jni
Copy link
Contributor

@jni jni commented Oct 16, 2017

Hi @kzielnicki! Thanks for nodebook, it's a great idea!

I think this should cover Python 3 support, but the installation of the notebook extension isn't working on IPython 6.x. Probably something needs to change in the install procedure that I haven't figured out yet.

Fixes #4.

@kzielnicki
Copy link
Contributor

Thanks for the PR @jni! The way the extension was previously installed was rather hacky, so this is a good opportunity to change that. The issue is the javascript component of the extension. The current setup copies the javascript directly to the jupyter extensions directory (outside the package wheel) because I didn't figure any other good way to seamlessly install it programmatically, but this workaround was never really ideal (and indeed the current hack seems to not work at all in python 3), so I'll work on a different approach.

@jni
Copy link
Contributor Author

jni commented Oct 17, 2017

@kzielnicki great, thanks! @Carreau pointed me to this page for the latest docs on installing Jupyter extensions:

http://jupyter-notebook.readthedocs.io/en/stable/extending/frontend_extensions.html?highlight=extensions#installing-and-enabling-extensions

@Carreau
Copy link

Carreau commented Oct 17, 2017

I can try to review and give extra comments (this week will tough though). The best would be to copy / get inspiration from jupyterlab as they are just an extension of the notebook server. I would also have a look at the fantastic work the Jupyter_Contrib folks are doing as they have an extension to install/uninstall other extensions.

@kzielnicki kzielnicki changed the base branch from master to py3 October 17, 2017 16:38
@kzielnicki
Copy link
Contributor

Thanks @Carreau and @jni! I had originally hoped to avoid having a two-step installation process, but it looks like this is going to be unavoidable with pip. I'm merging this PR to a py3 branch and taking a stab at updating the install from there.

@kzielnicki kzielnicki merged commit 36a12a8 into stitchfix:py3 Oct 17, 2017
@kzielnicki kzielnicki mentioned this pull request Oct 17, 2017
@jni jni deleted the py3 branch October 18, 2017 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants