Merge pull request github-linguist#1831 from github/return-nil-on-no-…

…ace-mode Set "missing" ace modes to `text`
stof · Dec 9, 2014 · 5a0c637 · 5a0c637
2 parents 855cc52 + 0cbcbd4
commit 5a0c637
Show file tree

Hide file tree

Showing 3 changed files with 164 additions and 159 deletions.
diff --git a/lib/linguist/language.rb b/lib/linguist/language.rb
@@ -269,8 +269,12 @@ def self.colors
 
     # Public: A List of languages compatible with Ace.
     #
+    # TODO: Remove this method in a 5.x release. Every language now needs an ace_mode
+    # key, so this function isn't doing anything unique anymore.
+    #
     # Returns an Array of Languages.
     def self.ace_modes
+      warn "This method will be deprecated in a future 5.x release. Every language now has an `ace_mode` set."
       @ace_modes ||= all.select(&:ace_mode).sort_by { |lang| lang.name.downcase }
     end