Release: Prerelease 8.6.0-beta.1 #30543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: jonniebigodes <[email protected]>
…tation Docs: Add CSF factory API documentation
…:storybookjs/storybook into jeppe/partially-revert-vite-allowedhosts
…e-allowedhosts Builder-Vite: Fix defaulting to allowing all hosts
github-actions
bot
added
the
release
github-actions
bot
requested review from
kylegach and
jonniebigodes
as code owners
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
13 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+85
to
+89
| document.getElementById('storybook-root').innerHTML = | ||
| `<p style="color: red; max-width: 70ch">${message.replaceAll( | ||
| '\n', | ||
| '<br/>' | ||
| )}<ul>${docs.map((doc) => `<li><a href='${doc}' target='_blank'>${doc}</a></li>`).join('')}<ul></p>`; |
There was a problem hiding this comment.
logic: Potential XSS vulnerability - hostname is inserted into innerHTML without sanitization
| // Import all stories from the stories file | ||
| import * as stories from './Button.stories'; | ||
|
|
||
| const { Primary, Secondary } = stories; |
There was a problem hiding this comment.
style: Secondary is destructured but never used in the tests
Suggested change
| const { Primary, Secondary } = stories; | |
| const { Primary } = stories; |
| // Import all stories from the stories file | ||
| import * as stories from './Button.stories'; | ||
|
|
||
| const { Primary, Secondary } = stories; |
There was a problem hiding this comment.
style: Secondary is destructured but never used in the tests
Suggested change
| const { Primary, Secondary } = stories; | |
| const { Primary } = stories; |
|
|
||
| const { Primary, Secondary } = stories; | ||
|
|
||
| test('renders primary button with default args', async () => { |
There was a problem hiding this comment.
logic: test is marked async but no await is used in the test
Suggested change
| test('renders primary button with default args', async () => { | |
| test('renders primary button with default args', () => { |
| expect(buttonElement).not.toBeNull(); | ||
| }); | ||
|
|
||
| test('renders primary button with overridden props', async () => { |
There was a problem hiding this comment.
logic: test is marked async but no await is used in the test
Suggested change
| test('renders primary button with overridden props', async () => { | |
| test('renders primary button with overridden props', () => { |
Comment on lines
+261
to
+263
| Previously, story properties such as `Story.args` or `Story.parameters` were accessed directly when reusing them in another story. While accessing them like this is still supported, it is deprecated in CSF Factories. | ||
|
|
||
| All of the story properties are now contained within a new property called `composed` and should be accessed from that property instead. For instance, `Story.composed.args` or `Story.composed.parameters`. |
There was a problem hiding this comment.
style: Important deprecation notice about direct property access. Consider highlighting this more prominently with a warning callout
UI: Fix tags sort for browser back-compat
storybook-bot
force-pushed
the
version-non-patch-from-8.6.0-beta.0
branch
from
85f3fe4 to
d8fdfbb
Compare
React: Fix incorrect import in preview.ts
storybook-bot
force-pushed
the
version-non-patch-from-8.6.0-beta.0
branch
from
d8fdfbb to
b7c3e43
Compare
storybook-bot
force-pushed
the
version-non-patch-from-8.6.0-beta.0
branch
from
b7c3e43 to
b2cb3c0
Compare
Co-authored-by: jonniebigodes <[email protected]>
Docs: Add documentation for `parameters.a11y.test`
storybook-bot
force-pushed
the
version-non-patch-from-8.6.0-beta.0
branch
from
b2cb3c0 to
6989cf5
Compare
Tags: Add story/meta usage telemetry
storybook-bot
force-pushed
the
version-non-patch-from-8.6.0-beta.0
branch
from
6989cf5 to
4d27fdc
Compare
shilman
added
freeze
|
View your CI Pipeline Execution ↗ for commit 4d27fdc.
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.6.0-beta.0to8.6.0-beta.1.Once this pull request is merged, it will trigger a new release of version
8.6.0-beta.1.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:parameters.a11y.test#30538testtags description #30548 (will also be patched)If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.6.0-beta.1