cleaning up get projects matching code

stringy05 · Dec 8, 2014 · a56124c · a56124c
1 parent 869c4f5
commit a56124c
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/models/services/get_jenkins_projects.rb b/models/services/get_jenkins_projects.rb
@@ -20,14 +20,12 @@ module GitlabWebHook
   class GetJenkinsProjects
     include Settings
 
-    def matching(details, exactly = false)
-      all.select do |project|
-        project.matches?(details.repository_uri, details.branch, details.full_branch_reference, exactly)
-      end.tap { |projects| log_matched(projects) }
+    def matching(details)
+      matching_projects(details, false)
     end
 
     def exactly_matching(details)
-      matching(details, true)
+      matching_projects(details, true)
     end
 
     def named(name)
@@ -48,6 +46,12 @@ def master(details)
 
     private
 
+    def matching_projects(details, exactly = false)
+      all.select do |project|
+        project.matches?(details.repository_uri, details.branch, details.full_branch_reference, exactly)
+      end.tap { |projects| log_matched(projects) }
+    end
+
     def all
       old_authentication_level = elevate_priviledges
       projects = Java.jenkins.model.Jenkins.instance.getAllItems(AbstractProject.java_class).map do |jenkins_project|