Misc. fixes in response to code review feedback

strogo · Feb 4, 2017 · 0ee1abf · 0ee1abf
1 parent 6a0a1af
commit 0ee1abf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/superset/assets/version_info.json b/superset/assets/version_info.json
diff --git a/superset/results_backends.py b/superset/results_backends.py
@@ -57,7 +57,9 @@ def get(self, key):
                     value_file
                 )
             except Exception as e:
-                logging.warn('Exception while trying to get %s: %s', key, e)
+                logging.warn('Error while trying to get key %s', key)
+                logging.exception(e)
+
                 return None
             else:
                 value_file.seek(0)
@@ -85,7 +87,9 @@ def delete(self, key):
                     }
                 )
             except Exception as e:
-                logging.warn('Exception while trying to delete %s: %s', key, e)
+                logging.warn('Error while trying to delete key %s', key)
+                logging.exception(e)
+
                 return False
             else:
                 return True
@@ -116,7 +120,9 @@ def set(self, key, value, timeout=None):
                 self._full_s3_key(key)
             )
         except Exception as e:
-            logging.warn('Exception while trying to set %s: %s', key, e)
+            logging.warn('Error while trying to set key %s', key)
+            logging.exception(e)
+
             return False
         else:
             return True