wip

stursby · Sep 10, 2023 · cddc93c · cddc93c
1 parent a802bb8
commit cddc93c
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 6 deletions.
diff --git a/packages/panels/resources/views/components/sidebar/group.blade.php b/packages/panels/resources/views/components/sidebar/group.blade.php
@@ -72,8 +72,8 @@ class="fi-sidebar-group-items flex flex-col gap-y-1"
                 :grouped="filled($label)"
                 :icon="$item->getIcon()"
                 :last="$loop->last"
-                :should-open-url-in-new-tab="$item->shouldOpenUrlInNewTab()"
                 :url="$item->getUrl()"
+                :should-open-url-in-new-tab="$item->shouldOpenUrlInNewTab()"
             >
                 {{ $item->getLabel() }}
             </x-filament-panels::sidebar.item>

diff --git a/packages/panels/src/Navigation/MenuItem.php b/packages/panels/src/Navigation/MenuItem.php
@@ -78,15 +78,13 @@ public function url(string | Closure | null $url, bool | Closure $shouldOpenInNe
         return $this;
     }
 
-
     public function openUrlInNewTab(bool | Closure $condition = true): static
     {
         $this->shouldOpenUrlInNewTab = $condition;
 
         return $this;
     }
 
-
     public function hidden(bool | Closure $condition = true): static
     {
         $this->isHidden = $condition;
@@ -143,7 +141,6 @@ public function getUrl(): ?string
         return $this->evaluate($this->url);
     }
 
-
     public function shouldOpenUrlInNewTab(): bool
     {
         return (bool) $this->evaluate($this->shouldOpenUrlInNewTab);

diff --git a/packages/panels/src/Navigation/NavigationItem.php b/packages/panels/src/Navigation/NavigationItem.php
@@ -125,7 +125,7 @@ public function sort(int | Closure | null $sort): static
 
     public function url(string | Closure | null $url, bool | Closure $shouldOpenInNewTab = false): static
     {
-        $this->shouldOpenUrlInNewTab = $shouldOpenInNewTab;
+        $this->openUrlInNewTab($shouldOpenInNewTab);
         $this->url = $url;
 
         return $this;

diff --git a/packages/widgets/src/StatsOverviewWidget/Stat.php b/packages/widgets/src/StatsOverviewWidget/Stat.php
@@ -146,7 +146,7 @@ public function openUrlInNewTab(bool $condition = true): static
 
     public function url(?string $url, bool $shouldOpenInNewTab = false): static
     {
-        $this->shouldOpenUrlInNewTab = $shouldOpenInNewTab;
+        $this->openUrlInNewTab($shouldOpenInNewTab);
         $this->url = $url;
 
         return $this;