-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement challenger #355
Merged
Merged
+749
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1fd51e6
to
17e8adc
Compare
17e8adc
to
a4fe4b8
Compare
ratankaliani
reviewed
Feb 1, 2025
20d9b85
to
241fc47
Compare
a4fe4b8
to
9396bb0
Compare
241fc47
to
bb77999
Compare
1cadc70
to
e843e67
Compare
f1d8817
to
e5243e8
Compare
74018f0
to
1b01c89
Compare
ratankaliani
reviewed
Feb 7, 2025
ratankaliani
reviewed
Feb 7, 2025
ratankaliani
reviewed
Feb 7, 2025
ratankaliani
reviewed
Feb 7, 2025
ratankaliani
reviewed
Feb 7, 2025
ratankaliani
reviewed
Feb 7, 2025
ratankaliani
reviewed
Feb 7, 2025
ratankaliani
reviewed
Feb 7, 2025
ratankaliani
reviewed
Feb 7, 2025
ratankaliani
reviewed
Feb 7, 2025
ratankaliani
reviewed
Feb 7, 2025
ratankaliani
reviewed
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me. We should finalize this after the contracts are finalized.
Will be ready for review after contracts are finalized. Won't be much change. |
e5243e8
to
be7e63f
Compare
139ee5d
to
9c09304
Compare
b721634
to
bd3e8d6
Compare
9b1cc31
to
5ce0b23
Compare
bd3e8d6
to
ce966a3
Compare
5ce0b23
to
5e774cd
Compare
e6ca209
to
831f4f8
Compare
b1442a3
to
77eba09
Compare
7abca1c
to
42ca7db
Compare
77eba09
to
44ef872
Compare
42ca7db
to
998681f
Compare
|
puma314
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements challenger binary interfaces with the OPSuccinctDisputeGame implemented in #342 to challenge a game if the claim is incorrect by calling
challenge()
function in the game contract.You can find a faulty game being challenged and resolved in favor of the challenger on ETH sepolia network: Faulty Game Contract, Challenge tx, Resolve tx
Notes on refac
The helper functions for game resolution are now in
FactoryTrait
since game resolution is both possible for the proposer and the challenger. There is a newenum Mode
to distinguish whether it's being called by proposer or challenger.