-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contracts): use DisputeGameFactory
#378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
459bee8
to
a77013b
Compare
|
a77013b
to
893277e
Compare
893277e
to
45ce5c8
Compare
DisputeGameFactory
8bcf36f
to
0b8afb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm that the proposer correctly calls DGF
, rather than OPDGF
after this change?
026e7a5
to
13d2085
Compare
38aa554
to
3400436
Compare
ratankaliani
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please fix the doc suggestions.
Removes unnecessary `OPSuccinctDisputeGameFactory`
3400436
to
c7b7ef8
Compare
PinelliaC
added a commit
to mantle-xyz/op-succinct
that referenced
this pull request
Feb 18, 2025
* feat: implement OPSuccinctFaultDisputeGame (succinctlabs#342) * feat: implement OPSuccinctFaultDisputeGame * apply comments * apply comments * chore: forge fmt * chore: forge fmt src/ test/ script/ * fix .gitmodules * fix .gitmodules * fix .gitmodules * fix: add missing checks * chore: forge fmt * fix .gitmodules * fix submodules * feat: implement with new spec * fix: handle first game * apply comments * fix: range vkey, public values from contract storage * missing fix from ^ * refac: use deadline, proposal status instead of clock * feat: use genesis l2 block number and hash for initial game * apply all comments * feat: make unchallenged games provable * apply comments * chore: remove warnings * test: add more tests * refac: use payable transfer instead of call * refac: remove claimant from claimData claimant never changes + can get from gameCreator() * fix: remove l2 chain id * apply comments * first * udpate doc * docs: make fault proof doc visible in the book * enable mermaid in book --------- Co-authored-by: Uma Roy <[email protected]> * docs: update `fault_proof_architecture.md` (succinctlabs#353) * docs: fix mermaid diagram * docs: update immutable params * docs: make doc more comprehensive * docs: minor updates * docs: make initalization more clear in terms of initial state * docs: add types section for new/modified types * fix: update OPSuccinctFaultDisputeGame with nits (succinctlabs#354) * fix: update OPSuccinctFaultDisputeGame with nits * docs: fix proving section * feat: upgrade to latest `kona` (succinctlabs#344) * feat: wip, running into fd issues bc zkvm mode * wip * add * wip * feat: program compiles * feat: still working through host issues, many of the scripts aren't compiling, making progress * wip * update * wip * feat: need to clean up host lib * feat: drop the kv_store so there are no conflicting locks * add * feat: move to latest kona * add * fix: DOckerfile * add * clippy * fix * redundant * fix * feat: todo * multi works * feat: small program works * feat: got store_oracle working * remove configs * feat: works with new blob provider * feat: docs * feat: works with upstream kona * add cycle tracking * add * feat: add driver with logging * fix: more efficient than before * feat: delete single * add * feat: general cleanup * fix * clippy * fix * clean * add * clean * rm bootinfowithbytesconfig * feat: new elf * add * refactor * add * remove configs * delete * remove test * update * fmt * feat: in parallel * feat: update elf * feat: simplify * host * feat: show entire diff * clippy * feat: trigger workflow * feat: fix cost estimator * add * chore: remove slack token (succinctlabs#364) * feat: remove slack token * tidy * feat: update * add * feat(fetcher): Use finalized block (succinctlabs#366) * feat(proposer): don't re-checkpoint (succinctlabs#365) * feat: dont recheckpoint in proposer * add * chore: `sp1-sdk` (succinctlabs#368) * docs: issue template * chore: `kona` + `sp1` upgrade (succinctlabs#376) * feat: kona upgrade * cargo fmt * delete safe_head_hash * fmt * rm * clippy * test fix * add * works * expose start_server * add * add * fix: Rust install * add * move witnessgen * add * lint * bump to 4.1.0 * one week rolling * add * feat: add * clean * add * ad * add * ELF * chore: Use `op-rs` upstream (succinctlabs#379) * feat(server): add proof mode (succinctlabs#380) * feat: add agg proof mode * add * chore: remove bls patch (succinctlabs#381) * feat: add agg proof mode * add * chore: remove bls patch * feat(server): debug logs (succinctlabs#351) * feat: boba debug branch * fix * enable push * fix * additional debug logs * build succinct-proposer first * feat: fetch in order * add * add * rm logs * fix * chore: fmt * chore: trigger docker build (succinctlabs#382) * feat: `kona` pectra tag (succinctlabs#384) * chore: kona pectra tag * docker elf * chore(server): `Arc` shared state (succinctlabs#385) * chore: wrap proposer config in arc * chore: fmt * fmt * feat(contracts): use `DisputeGameFactory` (succinctlabs#378) * feat(contracts): use `DisputeGameFactory` Removes unnecessary `OPSuccinctDisputeGameFactory` * fix: fix proposer to call DFG correctly * fix: make op-succinct validity working with op's dgf * cleanup * update * apply comments * feat(contracts): remove bond for validity DGF (succinctlabs#386) * feat(server): Only use `Arc<NetworkProver>` in real proof mode (succinctlabs#387) * feat(proposer): set default network private key * add * fmt --------- Co-authored-by: Ratan Kaliani <[email protected]> * chore: Switch to `OPSuccinctHost` (succinctlabs#389) * chore: clippy * chore: fix just update-parameters (succinctlabs#392) * chore: fix contract verification (succinctlabs#391) * chore(ci): docker tag (succinctlabs#393) * chore(client + ci): precompile annotation checks (succinctlabs#390) * chore: kzg_eval precompile * feat: bump to revm_precompile 0.16.1 * wip * chore: precompile * works * add * addgs * ci.yaml * remove unnecessary tests * ci * add * range elf * add * chore(ci): docker build * fix(proposer): bindings (succinctlabs#396) * chore: add go test * checkout * add * fix test * feat: update range elf * chore: remove unused code * elf: update range elf --------- Co-authored-by: fakedev9999 <[email protected]> Co-authored-by: Uma Roy <[email protected]> Co-authored-by: Ratan Kaliani <[email protected]> Co-authored-by: ratankaliani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
OPSuccinctFaultDisputeGameFactory
is removed.OPSuccinctDGFDeployer.s.sol
is updated to use OP'sDisputeGameFactory
.DisputeGameFactory
ABI and 2.DISPUTE_GAME_TYPE
flag is added so that we can create games through DisputeGameFactory.